Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQLServerMetadata constructor to set precision for string types #876

Merged
merged 5 commits into from
Nov 29, 2018

Conversation

lilgreenbird
Copy link
Member

@lilgreenbird lilgreenbird commented Nov 8, 2018

fixes issue #846

@codecov-io
Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #876 into dev will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev    #876      +/-   ##
===========================================
- Coverage     48.74%   48.6%   -0.14%     
+ Complexity     2813    2810       -3     
===========================================
  Files           118     118              
  Lines         27863   27877      +14     
  Branches       4637    4642       +5     
===========================================
- Hits          13582   13551      -31     
- Misses        12086   12134      +48     
+ Partials       2195    2192       -3
Flag Coverage Δ Complexity Δ
#JDBC42 48.18% <0%> (ø) 2770 <0> (+6) ⬆️
#JDBC43 48.55% <0%> (-0.09%) 2807 <0> (-2)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerMetaData.java 21.81% <0%> (-2.19%) 0 <0> (ø)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 40.65% <0%> (-6.6%) 13% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.68% <0%> (-1.71%) 108% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75.93% <0%> (-1.51%) 30% <0%> (-1%)
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 58.33% <0%> (-1.2%) 33% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 63.52% <0%> (-0.61%) 64% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.74% <0%> (-0.3%) 256% <0%> (-3%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.33% <0%> (-0.24%) 0% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.72% <0%> (-0.22%) 0% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.77% <0%> (-0.2%) 212% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46a5107...ac400e8. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.3 milestone Nov 20, 2018
@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC Nov 21, 2018
@lilgreenbird lilgreenbird merged commit bd89a10 into microsoft:dev Nov 29, 2018
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Nov 29, 2018
ulvii pushed a commit that referenced this pull request Nov 30, 2018
…876)

* added contructor for string length

* added comments

* updated javadoc

* updated javadoc
ulvii added a commit that referenced this pull request Nov 30, 2018
@lilgreenbird lilgreenbird deleted the tvp branch April 15, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

6 participants