Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random issue for SQLFloat random NaN value and improved TVPAllTypesTest for possible errors. #888

Merged
merged 5 commits into from Nov 26, 2018

Conversation

Projects
None yet
5 participants
@cheenamalhotra
Copy link
Member

commented Nov 22, 2018

No description provided.

cheenamalhotra added some commits Nov 22, 2018

Fix random issue for SQLFloat Datatype random NaN double value. Also …
…fixed error possibilities in TVPAllTypesTest
@codecov-io

This comment has been minimized.

Copy link

commented Nov 22, 2018

Codecov Report

Merging #888 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #888      +/-   ##
============================================
- Coverage     48.72%   48.72%   -0.01%     
- Complexity     2799     2814      +15     
============================================
  Files           116      118       +2     
  Lines         27877    27863      -14     
  Branches       4650     4637      -13     
============================================
- Hits          13584    13575       -9     
- Misses        12088    12092       +4     
+ Partials       2205     2196       -9
Flag Coverage Δ Complexity Δ
#JDBC42 48.26% <ø> (+0.12%) 2775 <ø> (+25) ⬆️
#JDBC43 48.56% <ø> (-0.1%) 2801 <ø> (+6)
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.99% <0%> (-0.44%) 89% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.94% <0%> (-0.31%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.46% <0%> (-0.27%) 263% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 64.12% <0%> (-0.21%) 64% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.28% <0%> (-0.2%) 4% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.45% <0%> (-0.12%) 0% <0%> (ø)
...va/com/microsoft/sqlserver/jdbc/TimeoutPoller.java 83.78% <0%> (ø) 9% <0%> (?)
...a/com/microsoft/sqlserver/jdbc/TimeoutCommand.java 100% <0%> (ø) 5% <0%> (?)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.11% <0%> (+0.11%) 260% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 161b0bb...d4539c3. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.3 milestone Nov 22, 2018

@cheenamalhotra cheenamalhotra dismissed stale reviews from lilgreenbird and peterbae via d4539c3 Nov 26, 2018

@ulvii

ulvii approved these changes Nov 26, 2018

@cheenamalhotra cheenamalhotra merged commit 218e736 into microsoft:dev Nov 26, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

ulvii added a commit that referenced this pull request Nov 30, 2018

ulvii added a commit that referenced this pull request Nov 30, 2018

Revert "Fix | Fix random issues for SQLFloat type and improved TVPAll…
…TypesTest for possible errors. (#888)"

This reverts commit 7b1ca05.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.