Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQLServerConnection documentation #984

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Conversation

peterbae
Copy link
Contributor

Addresses issue #980

@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #984 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev    #984      +/-   ##
===========================================
- Coverage     50.61%   50.6%   -0.01%     
  Complexity     2921    2921              
===========================================
  Files           120     120              
  Lines         27996   27996              
  Branches       4681    4681              
===========================================
- Hits          14170   14168       -2     
- Misses        11530   11531       +1     
- Partials       2296    2297       +1
Flag Coverage Δ Complexity Δ
#JDBC42 50.1% <ø> (-0.04%) 2877 <ø> (-1)
#JDBC43 50.51% <ø> (+0.02%) 2914 <ø> (-2) ⬇️
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 46.43% <ø> (ø) 342 <0> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 58.57% <0%> (-1.19%) 33% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.58% <0%> (-0.17%) 0% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (+0.43%) 43% <0%> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 62.5% <0%> (+0.43%) 91% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (+1.09%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78efb57...969d419. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.3.0 milestone Mar 12, 2019
@peterbae peterbae merged commit f189871 into microsoft:dev Mar 13, 2019
@ecki
Copy link
Contributor

ecki commented Mar 13, 2019

Confirmed, thanks!

@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

6 participants