Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom settings through env params for NAV and Clients #125

Merged
merged 4 commits into from Dec 16, 2017
Merged

Implement custom settings through env params for NAV and Clients #125

merged 4 commits into from Dec 16, 2017

Conversation

tfenster
Copy link
Contributor

@tfenster tfenster commented Dec 4, 2017

This addition allows to set customNavSettings, customWinSettings and customWebSettings to set arbitray config settings for the NAV server instance, ClickOnce Windows Client and WebClient. The format is:
<variablename>="<key1>=<value1>,<key2>=<value2>"
e.g.
customNavSettings="EnableDebbuging=true,ReportPDFFontEmbedding=false"
In cases where the config setting doesn't exist, the script creates it. Setting or creating a config value is also shown in the log

Tested with 2017-cu5-de and 2018-rtm-de

Copy link
Contributor Author

@tfenster tfenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to handle non-existent JSON settings as well

@freddydk
Copy link
Contributor

freddydk commented Dec 4, 2017

SetupClickOnce exists in all version folders, you have only modified the one in 100.
Today they are identical, but some at least the prereqs are different for some of the older versions (which is the reason for copying them out)
The Web Configuration should be done in SetupWebClient (which also is in the version folders) - SetupWebConfiguration should be left empty for override purposes.

@tfenster
Copy link
Contributor Author

tfenster commented Dec 5, 2017

Yes, I wanted to get your feedback before copying to all folders.

SetupWebClient vs. SetupWebConfiguration: As it is the same in all releases I thought it might make sense to put it in the central one instead of copying. But I'll move it. 2017 is the only release where we need to support web.config and navsettings.json, right? 2013 to 2016 is web.config only and 2018 navsettings.json only?

@freddydk
Copy link
Contributor

freddydk commented Dec 5, 2017

Thanks
2017 is only web.config
2018 is only navsettings.json
There were some preview builds in between with both, but we are not going to rebuild those.

@tfenster
Copy link
Contributor Author

tfenster commented Dec 5, 2017

ok, moved the parts around

@freddydk freddydk merged commit 6764453 into microsoft:master Dec 16, 2017
@freddydk
Copy link
Contributor

Merged, thanks Tobias

@tfenster tfenster mentioned this pull request Dec 31, 2017
@fvet
Copy link

fvet commented Apr 14, 2018

What would be the format to pass these customsettings via the additionalParameters?

New-CSideDevContainer -additionalParameters @("-e customNavSettings=ApiServicesEnabled=true")

@freddydk
Copy link
Contributor

Use new-navcontainer instead of new-csidedevcontainer.
New-csidedevcontainer is only there not to break people who has used that, you can see in the implementation that new-csidedevcontainer just calls new-navcontainer https://github.com/Microsoft/navcontainerhelper/blob/master/ContainerHandling/New-CSideDevContainer.ps1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants