Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConPTY Support #236

Merged
merged 56 commits into from Dec 21, 2018

Conversation

Projects
None yet
5 participants
@Tyriar
Copy link
Member

commented Oct 19, 2018

This introduces ConPTY support to node-pty which will be used when the Windows version is >=17692, there will also be a setting to allow consumers to say which to use.

Fixes #7
Fixes #168
Fixes #216

TODO

Tyriar added some commits Dec 19, 2018

Revert "Resolve TODO"
This reverts commit c81796e.
@Tyriar

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2018

@Eugeny also be warned the PR isn't complete just yet, the terminal's aren't cleaned up after they exit and no event is fired for example.

@Tyriar Tyriar force-pushed the dev/migrie/f/conpty branch from 5af3c17 to 7125d38 Dec 21, 2018

Tyriar added some commits Dec 21, 2018

@Astrantia

This comment has been minimized.

Copy link

commented Dec 21, 2018

@Tyriar Is this ready to be used in Code Insiders?

@Tyriar

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2018

@Astrantia very soon 😃

@Tyriar

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2018

Let's do this 🚀 💥 😱 🏗 🏎 😎

@Tyriar Tyriar merged commit cce934f into master Dec 21, 2018

2 checks passed

Microsoft.node-pty #20181221.12 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.