Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Onenote submission #181

Closed
kkiiskin opened this issue Sep 22, 2016 · 1 comment
Closed

Bug in Onenote submission #181

kkiiskin opened this issue Sep 22, 2016 · 1 comment
Labels
Issue type - bug Bugs in existing code that needs to be fixed.

Comments

@kkiiskin
Copy link

Table "mdl_onenote_assign_pages" has apparently been changed to "mdl_local_onenote_assign_pages" at some point.

But in mod/assign/submission/onenote/locallib.php, function save(), old name is still used (twice) and it causes an error when student is trying to saving submission.

Example locallib.php line 205 or so:
...
// Get OneNote page id.
$record = $DB->get_record('onenote_assign_pages',
array("assign_id" => $submission->assignment, "user_id" => $submission->userid));

@jamesmcq jamesmcq added the Issue type - bug Bugs in existing code that needs to be fixed. label Oct 21, 2016
@jamesmcq jamesmcq modified the milestone: Release 20161118 Oct 21, 2016
@jamesmcq jamesmcq modified the milestones: Release 20161118, Next Release Dec 2, 2016
@jamesmcq
Copy link
Contributor

jamesmcq commented Mar 1, 2017

This should now be resolved. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue type - bug Bugs in existing code that needs to be fixed.
Projects
None yet
Development

No branches or pull requests

2 participants