Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

[Ssh Key File] ~ in filename will be replaced by _ in Chrome. #1574

Closed
wangcan0329 opened this issue Oct 22, 2018 · 8 comments
Closed

[Ssh Key File] ~ in filename will be replaced by _ in Chrome. #1574

wangcan0329 opened this issue Oct 22, 2018 · 8 comments

Comments

@wangcan0329
Copy link
Contributor

Now we added namespace as prefix to the jobname and joint with ~, if we click private key the file will be downloaded but the ~ in file name will be replaced by _ automatically in Chrome. Which will cause the step 3 and 4 failed since the name changed.

@wangcan0329 wangcan0329 self-assigned this Oct 22, 2018
@DongZhaoYu
Copy link
Member

@wangcan0329 can we provide a more efficient way to users by opening a console in webport and connect to the container? So users wouldn't need to download the key file and connect to the container manually.

@Gerhut
Copy link
Member

Gerhut commented Oct 23, 2018

I don't think we should rely on filename auto-generating feature of browser / local file system. Instead of rename the URI of the key file I prefer add a notice like "Make sure your downloaded file named some-key".

In the future, I propose providing a shell script includes current three commands and encourage user to use the commands like

$ bash <(curl http://rest-server/v1/api/user/foo/jobs/bar/containers/baz/connect.sh)

to connect the container, as well as giving the download link of key file as tech details.

@wangcan0329
Copy link
Contributor Author

@DongZhaoYu Actually I had a simple test on web ssh tool but didn't get time to have a further investigation. I will consider to add this feature but I don't think this is high priority thing.

@wangcan0329
Copy link
Contributor Author

@Gerhut Agree. We can consider to combine these three commands into one script.

@wangcan0329
Copy link
Contributor Author

Chrome replace the tilde ~ with an underscore _ is by design to avoid potential filename issue on Windows . please refer to Character “~” will be automatically changed to “_” in filename during downloading by Chrome

@fanyangCS
Copy link
Contributor

Can we detect whether the page is rendered by Chrome or not? if yes, we can show a warning in the page.

@wangcan0329 wangcan0329 added this to the current release milestone Nov 21, 2018
@fanyangCS
Copy link
Contributor

we publish it as a known issue.

@scarlett2018 scarlett2018 added this to triaged in bugs Feb 1, 2019
@scarlett2018 scarlett2018 removed this from the current release milestone Feb 3, 2019
@scarlett2018
Copy link
Member

PAI does not print the url anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
bugs
triaged
Development

No branches or pull requests

6 participants