Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

No validation when submitting job by json #2375

Closed
mzmssg opened this issue Mar 22, 2019 · 0 comments
Closed

No validation when submitting job by json #2375

mzmssg opened this issue Mar 22, 2019 · 0 comments

Comments

@mzmssg
Copy link
Member

mzmssg commented Mar 22, 2019

Organization Name:
Mircosoft

Short summary about the issue/question:
Submitting job by "import json" has a validataion, but sumbitting by "edit json" without.

image

OpenPAI Environment:

  • OpenPAI version: master

Test Case

invalid submit json :
{
"jobName": "123",
"image": "",
"authFile": "",
"dataDir": "",
"outputDir": "",
"codeDir": "",
"virtualCluster": "default",
"gpuType": "",
"retryCount": 0,
"taskRoles": [
{
"name": "123",
"taskNumber": 1,
"cpuNumber": 1,
"memoryMB": 1000,
"shmMB": 64,
"gpuNumber": 0,
"minFailedTaskCount": 1,
"minSucceededTaskCount": null,
"command": "123",
"portList": []
}
],
"jobEnvs": {},
"extras": {}
}
should alert:
Please fix the invalid parameters: image: Value must match the pattern ^\S+$

valid submit json:
{
"jobName": "123",
"image": "123",
"authFile": "",
"dataDir": "",
"outputDir": "",
"codeDir": "",
"virtualCluster": "default",
"gpuType": "",
"retryCount": 0,
"taskRoles": [
{
"name": "123",
"taskNumber": 1,
"cpuNumber": 1,
"memoryMB": 1000,
"shmMB": 64,
"gpuNumber": 0,
"minFailedTaskCount": 1,
"minSucceededTaskCount": null,
"command": "123",
"portList": []
}
],
"jobEnvs": {},
"extras": {}
}
should save values

@mzmssg mzmssg added the v0.11.0 label Mar 22, 2019
@scarlett2018 scarlett2018 added this to the April Middle Release milestone Mar 22, 2019
yxwithu added a commit that referenced this issue Apr 8, 2019
yxwithu added a commit that referenced this issue Apr 8, 2019
…ist-filter UI fix #2479 (#2510)

* fix a bug, add validation when submitting job by json

bug issue:
#2375

* fix a bug: Job List-filter UI

issue: #2479

this issue has two parts, the first was fixed before, this commit fix the second.

* Update the code to make it more standardized
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants