This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
add job Envs #1544
Merged
add job Envs #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The UI looks like below: |
Gerhut
reviewed
Oct 19, 2018
| if (data.jobEnvs) { | ||
| for (let key in data.jobEnvs) { | ||
| if (data.jobEnvs.hasOwnProperty(key)) { | ||
| jobEnvs = jobEnvs.concat(key, '=', data.jobEnvs[key], '\n'); |
There was a problem hiding this comment.
There are indeed injection risks, javascript injection and bash injection.
I will take more investigation.
There was a problem hiding this comment.
It's some kind of complicated.
We pass the env.list to docker command, which would quote.
https://github.com/Microsoft/pai/blob/4491119258197ccd6700f295b3ff518ed4a83c81/src/rest-server/src/templates/yarnContainerScript.mustache#L277
So if we quote it with single/double quote, the value would corrupt, as below:
hayua@stcvl-131:~$ cat env.list
double_quote="with double quote"
single_quote='with single quote'
hayua@stcvl-131:~$ sudo docker run -it --env-file env.list ubuntu env |grep quote
double_quote="with double quote"
single_quote='with single quote'
There was a problem hiding this comment.
Hi @Gerhut,
Now the "env list' was passing to 'docker run', which would take care of 'encoding and escaping'.
We should pass it as it is.
Gerhut
approved these changes
Oct 26, 2018
fanyangCS
reviewed
Oct 26, 2018
|
Not yet, I will add doc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1527.