This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
fix driver bug #1829
Merged
fix driver bug #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
YanjieGao
approved these changes
Dec 6, 2018
YanjieGao
reviewed
Dec 6, 2018
| @@ -52,8 +52,6 @@ spec: | |||
| value: {{ cluster_cfg['rest-server']['default-pai-admin-password'] }} | |||
| - name: ETCD_URI | |||
| value: {{ cluster_cfg['rest-server']['etcd-uris'] }} | |||
| - name: NV_DRIVER | |||
| value: /var/drivers/nvidia/current | |||
There was a problem hiding this comment.
for example if on aks env dir is diff with this, need tell user to change this config?
There was a problem hiding this comment.
No, this can be hardcoded. My plan is all gpu-consumers(job-exporter, node-manager) use this symbolic link to find current active driver. And it's driver's responsibility to make this symbolic link pointing to the right place, whether it is pre-installed place or our installation place.
|
@Gerhut yes, I know that, but I didn't know when I submit previous PR, since it can be hardcoded, I'll just hardcoding in script instead of passing the env variable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems rest-server will not pass environment variable into yarn-script. just hardcode in yarn-script since it is hardcoded anyway.