This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerhut
requested review from
fanyangCS,
wangcan0329,
sterowang and
scarlett2018
February 3, 2019 09:55
1 similar comment
fanyangCS
approved these changes
Feb 13, 2019
Gerhut
force-pushed
the
qixcheng/webportal-plugin/submit-simple-job
branch
from
February 13, 2019 09:00
55cfa82
to
12e75a3
Compare
Hi @squirrelsc, since @scarlett2018 is in holiday, could you please review this document and figure out where to improve? |
squirrelsc
suggested changes
Feb 13, 2019
abuccts
reviewed
Feb 14, 2019
contrib/submit-simple-job/App/Components/FormControls/Select.tsx
Outdated
Show resolved
Hide resolved
abuccts
reviewed
Feb 14, 2019
abuccts
reviewed
Feb 14, 2019
abuccts
approved these changes
Feb 14, 2019
Gerhut
force-pushed
the
qixcheng/webportal-plugin/submit-simple-job
branch
from
February 17, 2019 10:07
86b090e
to
ceb59c8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.