Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

fix: code_dir_size report incorrect error message #2388

Merged
merged 3 commits into from
Mar 25, 2019
Merged

fix: code_dir_size report incorrect error message #2388

merged 3 commits into from
Mar 25, 2019

Conversation

debuggy
Copy link
Contributor

@debuggy debuggy commented Mar 25, 2019

  • Add a condition when $code_dir_size is less than 0.

@debuggy debuggy requested review from sunqinzheng, abelsquidhead and abuccts and removed request for abelsquidhead March 25, 2019 05:52
@coveralls
Copy link

coveralls commented Mar 25, 2019 •
edited

Coverage Status

Coverage increased (+0.01%) to 52.659% when pulling f09e864 on mintao/fix_code_dir_size into 43269e7 on master.

@debuggy debuggy requested a review from Gerhut March 25, 2019 05:59
@debuggy
Copy link
Contributor Author

debuggy commented Mar 25, 2019 •
edited

Related bug issue: #2387

fanyangCS
fanyangCS approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@fanyangCS fanyangCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fanyangCS fanyangCS mentioned this pull request Mar 25, 2019
Closed
@debuggy debuggy merged commit e1479b3 into master Mar 25, 2019
@debuggy debuggy deleted the mintao/fix_code_dir_size branch June 29, 2019 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanyangCS fanyangCS fanyangCS approved these changes

@abuccts abuccts abuccts approved these changes

@sunqinzheng sunqinzheng Awaiting requested review from sunqinzheng

@Gerhut Gerhut Awaiting requested review from Gerhut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@debuggy @coveralls @fanyangCS @abuccts