Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Fix script entrypoint to correctly redirect stdout/stderr #2522

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

mzmssg
Copy link
Member

@mzmssg mzmssg commented Apr 9, 2019

This is full yarn entrypoint:
exec /bin/bash -c "source YarnContainerScripts/2.sh 1>$LAUNCHER_LOG_DIR/stdout 2>$LAUNCHER_LOG_DIR/stderr"
source will extract the exit_handler to parent process and bypass the redirect.

There are 2 fix options:

  1. replace source with bash
  2. move redirect out of quotation

Source:
image

Bash:
image

@mzmssg mzmssg requested review from abuccts and yqwang-ms April 9, 2019 09:17
@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.932% when pulling 66c5009 on zimiao/fix_script_launcher into 5b3f044 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.932% when pulling 66c5009 on zimiao/fix_script_launcher into 5b3f044 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.932% when pulling 66c5009 on zimiao/fix_script_launcher into 5b3f044 on master.

@mzmssg mzmssg merged commit 693a68f into master Apr 9, 2019
@mzmssg mzmssg deleted the zimiao/fix_script_launcher branch April 9, 2019 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants