Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile to support building shared library for Linux #26

Merged
merged 1 commit into from Apr 23, 2018

Conversation

kmaehashi
Copy link
Contributor

This PR fixes the Makefile so that shared library that provides PICT API can be built.

@msftclas
Copy link

msftclas commented Apr 22, 2018

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Although, I'd suggest you move the all: line to be the first (and default) target now that all and pict target differ.

@jaccz jaccz merged commit 8e165b1 into microsoft:master Apr 23, 2018
@kmaehashi kmaehashi deleted the shared-library branch April 23, 2018 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants