Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: more testing-friendly trace #14264

Merged
merged 1 commit into from
May 18, 2022

Conversation

pavelfeldman
Copy link
Member

No description provided.

Copy link
Member

@rwoll rwoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's add some test coverage either here or in follow-up! 😄

@pavelfeldman
Copy link
Member Author

Yeah, I'm figuring out how to cover it with the test. We need a new harness for component tests w/ tracing...

@pavelfeldman pavelfeldman merged commit 432c52d into microsoft:main May 18, 2022
aslushnikov pushed a commit to aslushnikov/playwright that referenced this pull request May 19, 2022
aslushnikov added a commit that referenced this pull request May 19, 2022
SHA 432c52d

Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants