Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stricter condition for Firefox codegen tests workaround #20998

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

aslushnikov
Copy link
Collaborator

This patch fixes the following tests on WebKit @ Darwin:

  • library/inspector/cli-codegen-2.spec.ts:197:7 › cli codegen › should download files
  • library/inspector/cli-codegen-2.spec.ts:428:7 › cli codegen › should update hover model on action

This patch fixes the following tests on WebKit @ Darwin:
- library/inspector/cli-codegen-2.spec.ts:197:7 › cli codegen › should download files
- library/inspector/cli-codegen-2.spec.ts:428:7 › cli codegen › should update hover model on action
@aslushnikov
Copy link
Collaborator Author

TBR: @dgozman

@aslushnikov aslushnikov merged commit 1b441ef into microsoft:main Feb 17, 2023
@aslushnikov aslushnikov deleted the fix-webkit-codegen-tests branch February 17, 2023 20:19
aslushnikov added a commit that referenced this pull request Feb 17, 2023
…s workaround

This patch fixes the following tests on WebKit @ Darwin:
- library/inspector/cli-codegen-2.spec.ts:197:7 › cli codegen › should
download files
- library/inspector/cli-codegen-2.spec.ts:428:7 › cli codegen › should
update hover model on action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant