Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ct): vue revert json object as prop #22005

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

sand4rt
Copy link
Collaborator

@sand4rt sand4rt commented Mar 27, 2023

related to: #21400 (comment).

@pavelfeldman pavelfeldman merged commit bfea952 into microsoft:main Mar 28, 2023
@pavelfeldman
Copy link
Member

@sand4rt do we want it in 1.32.2?

@sand4rt
Copy link
Collaborator Author

sand4rt commented Mar 28, 2023

@pavelfeldman Would be nice, if it is not to much of a hassle.

It did not effect to many users tho. Only the ones that where using interfaces in combination with separate variables as props:

interface Props { test: string } // needs to be a `type Props = { test: string }` or `interface Props extends JsonObject { test: string }`

const props: Props = { test: 'boop' }

test('test', async ({ mount }) => {
  await mount(Component, { props }); // throws type error, props is not a JsonObject
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants