Merge 358244f into e13c412

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 1.14.2
+* Fixed bug when completion line overlap day off periods in some cases
+
 ## 1.14.1
 * Fixed bug with wrongly positioned "group expand/collapse" icon when horizontal scrolling is presented and the icon now has fixed horizontal position as for single "expand/collapse" icons
 * Fixed bug with broken removing of some important selectors 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "powerbi-visuals-gantt",
-  "version": "1.14.1",
+  "version": "1.14.2",
   "description": "A Gantt chart is a type of bar chart which illustrates a project timeline or schedule. The Gantt Chart visual shows the Tasks, Start Dates, Durations, % Complete, and Resources for a project. The Gantt Chart visual can be used to show current schedule status using percent-complete shadings and a vertical \"TODAY\" line. The Legend may be used to group or filter tasks based upon data values.",
   "repository": {
     "type": "git",

pbiviz.json

@@ -1,10 +1,10 @@
 {
   "visual": {
     "name": "Gantt",
-    "displayName": "Gantt 1.14.1",
+    "displayName": "Gantt 1.14.2",
     "guid": "Gantt1448688115699",
     "visualClassName": "Gantt",
-    "version": "1.14.1",
+    "version": "1.14.2",
     "description": "A Gantt chart is a type of bar chart which illustrates a project timeline or schedule. The Gantt Chart visual shows the Tasks, Start Dates, Durations, % Complete, and Resources for a project. The Gantt Chart visual can be used to show current schedule status using percent-complete shadings and a vertical \"TODAY\" line. The Legend may be used to group or filter tasks based upon data values.",
     "supportUrl": "https://community.powerbi.com",
     "gitHubUrl": "https://github.com/Microsoft/powerbi-visuals-gantt"

src/gantt.ts

@@ -1792,6 +1792,10 @@ module powerbi.extensibility.visual {
             const taskDaysOffColor: string = this.viewModel.settings.daysOff.fill;
             const taskDaysOffShow: boolean = this.viewModel.settings.daysOff.show;
 
+            taskSelection
+                .selectAll(Selectors.TaskDaysOff.selectorName)
+                .remove();
+
             if (taskDaysOffShow) {
                 let tasksDaysOff: UpdateSelection<TaskDaysOff> = taskSelection
                     .selectAll(Selectors.TaskDaysOff.selectorName)
@@ -1833,11 +1837,6 @@ module powerbi.extensibility.visual {
                 tasksDaysOff
                     .exit()
                     .remove();
-
-            } else {
-                taskSelection
-                    .selectAll(Selectors.TaskDaysOff.selectorName)
-                    .remove();
             }
         }