Draw label for links as "Source-Destination:Value" - fix applying set…

…tings (#23)
microsoft · Aug 18, 2017 · fe22ced · fe22ced
1 parent 28a87a5
commit fe22ced
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.3.1
+
+* Fix applying settings of link labels
+
 ## 1.3.0
 
 * Add link data labels displaying

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "powerbi-visuals-sankey",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "Sankey is a type of flow diagram in which the width of the series is in proportion to the quantity of the flow.  Use it to find major contributions to an overall flow.",
   "repository": {
     "type": "git",

diff --git a/pbiviz.json b/pbiviz.json
@@ -1,10 +1,10 @@
 {
   "visual": {
     "name": "SankeyDiagram",
-    "displayName": "Sankey 1.3.0",
+    "displayName": "Sankey 1.3.1",
     "guid": "SankeyDiagram1446463184954",
     "visualClassName": "SankeyDiagram",
-    "version": "1.3.0",
+    "version": "1.3.1",
     "description": "Sankey is a type of flow diagram in which the width of the series is in proportion to the quantity of the flow.  Use it to find major contributions to an overall flow.",
     "supportUrl": "http://community.powerbi.com",
     "gitHubUrl": "https://github.com/Microsoft/powerbi-visuals-sankey"

diff --git a/src/visual.ts b/src/visual.ts
@@ -1346,7 +1346,9 @@ module powerbi.extensibility.visual {
 
             textPathSelection
                 .enter()
-                .append("textPath")
+                .append("textPath");
+
+            textPathSelection
                 .attr({
                     startOffset: "50%",
                     href: (link: SankeyDiagramLink) => `#${(link.source.label.internalName || "").replace(/\W*/g,"")}-${(link.destination.label.internalName || "").replace(/\W*/g,"")}`