Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring package.json. Source maps must be used only for unit tests #9

Merged
merged 3 commits into from Apr 6, 2017
Merged

Refactoring package.json. Source maps must be used only for unit tests #9

merged 3 commits into from Apr 6, 2017

Conversation

savvinsergey
Copy link
Contributor

Task - 16169

@msftclas
Copy link

@savvinsergey,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 70.432% when pulling d14811e on savvinsergey:master into 94ff2ab on Microsoft:master.

ignatvilesov
ignatvilesov suggested changes Mar 27, 2017
View reviewed changes
Copy link
Contributor

@ignatvilesov ignatvilesov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change the major version of the package

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 70.432% when pulling 5062ce3 on savvinsergey:master into 94ff2ab on Microsoft:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 70.432% when pulling 9e4b064 on savvinsergey:master into 94ff2ab on Microsoft:master.

ignatvilesov
ignatvilesov approved these changes Apr 3, 2017
View reviewed changes
Copy link
Contributor

@ignatvilesov ignatvilesov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's the spelling mistake in the pull request's description.
Please squash your commits.

@savvinsergey savvinsergey changed the title Refactoring pakacge.json. Source maps must be used only for unit tests Refactoring package.json. Source maps must be used only for unit tests Apr 3, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 70.432% when pulling 5d9942b on savvinsergey:master into 94ff2ab on Microsoft:master.

@savvinsergey
Copy link
Contributor Author

Done

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 70.432% when pulling 5ef98dc on savvinsergey:master into 94ff2ab on Microsoft:master.

@AviSander AviSander merged commit 43b579a into microsoft:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignatvilesov ignatvilesov ignatvilesov approved these changes

Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@savvinsergey @msftclas @coveralls @ignatvilesov @AviSander