New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difficulties closing palette when in JavaScript view on small screen #2000
Comments
Good catch. Blockly recognized the ESC key to close the flyout. We should at least have a keystroke. But this doesn't solve the problem on mobile. We could also close the flyout if you click on it (but not on a block). But that isn't the greatest solution either. Perhaps we need a X (close) button on the flyout in mobile? |
Clicking outside a block on the flight should close, just like any other dialog.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Tom Ball <notifications@github.com>
Sent: Saturday, April 29, 2017 3:06:02 PM
To: Microsoft/pxt
Cc: Subscribed
Subject: Re: [Microsoft/pxt] Difficulties closing palette when in JavaScript view on small screen (#2000)
Good catch. Blockly recognized the ESC key to close the flyout. We should at least have a keystroke.
But this doesn't solve the problem on mobile. We could also close the flyout if you click on it (but not on a block). But that isn't the greatest solution either.
Perhaps we need a X button on the flyout in mobile?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fissues%2F2000%23issuecomment-298197418&data=02%7C01%7Cjhalleux%40microsoft.com%7Cfe444dc5ff884e02bddb08d48f4bee4d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636291003660616716&sdata=9Bc0b5ZcCz2%2FZ%2Fu2ou6ih79G%2FaAJjjRRfcdN1D%2FKRnM%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KXlDLNTJ2GeFogeAwrnQc09xFeIdks5r07RKgaJpZM4NMOHP&data=02%7C01%7Cjhalleux%40microsoft.com%7Cfe444dc5ff884e02bddb08d48f4bee4d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636291003660616716&sdata=yVSi8KvyUJbwwNItSahxpnrCq%2Fr4tO28UcSECwr%2BTJI%3D&reserved=0>.
|
Doesn't work for me? I have to click outside of the grey area, and if the grey area takes up the whole screen, there is no way to click outside the grey area. |
Ah I see, great, thanks, I misinterpreted. So you mean 'we should fix this problem by changing the functionality, so that when you click on the grey area it closes the fly out'. Got it. Thanks :) |
Matching blockly's toolbox behaviour, we don't close the flyout when you tap the background of the flyout. For big flyouts on small screens, you can still close the flyout by tapping the category again. (Just like in Blockly). |
This has been fixed in master. We recognise the escape key and limit the width of a block in the flyout. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
See screenshot below. When running on a small screen in javascript mode, I can't seen to find a sensible way to close the palette when it opens with very long names, as the scroll bars don't scroll outside of the popup region.
Tried on both live and beta today.
A small workaround seems to be to press the arrow that expands and collapses the advanced palette, but I found this by chance, and I'm not sure it's obvious to all users.
Just sending this in as feedback, as I suspect this will affect the mobile experience if anyone goes into javascript view to patch a couple of lines of code when on mobile.
BETA
pxt.microbit.org version: 0.12.5
Microsoft MakeCode version: 0.12.63
C++ runtime version: v2.0.0-rc9
LIVE
pxt.microbit.org version: 0.9.77
Microsoft MakeCode version: 0.12.25
C++ runtime version: v2.0.0-rc8
The text was updated successfully, but these errors were encountered: