Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infection game does not seem to translate well into blocks #2340

Closed
fizban99 opened this issue Jun 23, 2017 · 4 comments
Closed

Infection game does not seem to translate well into blocks #2340

fizban99 opened this issue Jun 23, 2017 · 4 comments
Assignees
Labels

Comments

@fizban99
Copy link

I am taking a look at the infection game but I guess is one example of code that cannot be converted into blocks. I get an error if I try to see the Blocks equivalent. I thought that everything could be converted, although some things would become grey blocks... There seems to be exceptions, though... If that is the case, it would be nice to get a warning either in the infection project page or in the pxt editor itself... https://pxt.microbit.org/projects/infection

@riknoll riknoll added the bug label Jun 23, 2017
@riknoll riknoll self-assigned this Jun 23, 2017
@riknoll riknoll added the P2 label Jun 23, 2017
@riknoll
Copy link
Member

riknoll commented Jun 23, 2017

This is an issue with the block compilation; looks like we are not inferring the type of the "players" variable correctly. It's being initialized to a string rather than an array. The likely culprit is the blockly "length" block because it works for both strings and arrays and might be confusing things.

@riknoll
Copy link
Member

riknoll commented Jun 29, 2017

Deferring to #2349 which has a better repro

@riknoll riknoll closed this as completed Jun 29, 2017
@microbit-mark
Copy link
Contributor

micro:bit-support:4078
@riknoll @pelikhan @abchatra Have another support ticket about this. The code still does not convert to blocks,

https://makecode.microbit.org/94575-30587-68669-98014

though following this ticket through it looks like the underlying issue was resolved.

As with original request here, the docs should be updated if this project can only run from Javascript

@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants