Skip to content
This repository has been archived by the owner on Apr 14, 2022. It is now read-only.

Use-before-def reported for class fields without default values #395

Closed
melwas opened this issue Nov 14, 2018 · 5 comments
Closed

Use-before-def reported for class fields without default values #395

melwas opened this issue Nov 14, 2018 · 5 comments
Assignees

Comments

@melwas
Copy link

melwas commented Nov 14, 2018

Environment data
VS Code version: 1.29.0
Extension version (available under the Extensions sidebar): 2018.10.1
OS and version: OSX
Python version (& distribution if applicable, e.g. Anaconda): python 3.7
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv

Actual behavior
Python 3.7 dataclass properties are incorrectly reported as "used before definition". The same syntax with default values added is not reported.

screen shot 2018-11-14 at 07 54 00

Expected behavior
The properties are not reported.

Steps to reproduce:
See screenshot above.

BTW: is it possible (as a workaround to above issue) to suppress warnings for a given block/line?

@jakebailey jakebailey self-assigned this Nov 14, 2018
@jakebailey
Copy link
Member

jakebailey commented Nov 14, 2018

The analyzer only offers basic detection of use-before-def and unresolved imports, and doesn't have the ability to disable checks per line (#264). What you can do in the meantime is disable the diagnostic in your settings, like:

"python.analysis.disabled": [
    "use-before-def"
]

And use something like pylint which I don't believe will misreport this (with the downside that it can only be run on save, while the language server can do these checks instantly).

@jakebailey jakebailey changed the title Incorrect reporting of dataclass properties Use-before-def reported for class fields without default values Nov 14, 2018
@lukaselmer
Copy link

I have the same issue.

@jakebailey there is a typo in anaysis - it should be

"python.analysis.disabled": [
    "use-before-def"
]

@jakebailey
Copy link
Member

Agh, yeah, sorry.

@koliyo
Copy link

koliyo commented Dec 14, 2018

I hope these issues become a priority. VS code should really encourage the usage of the typing syntax!

@brettcannon
Copy link
Member

This was noticed on Stack Overflow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants