New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codepush rollbacks after successful deploys when using wix/react-native-navigation #875
Comments
After spending several hours on this, i finally found a solution/workaround:
and then just rendered that component in the main screen. This way, I'm using the recommended decorator method. Not sure what kind of sorcery that decorator is doing that I couldn't replicate with sync/notifyAppReady. Also make sure that in AppDelegate.m you have the right
|
Hi @grigored, got it, thank you for the information, please feel free to reopen if needed. Also let us know if you have any questions or see any issues. |
An issue I definitely see is what I mentioned at 3: the codepush HOC doesn't copy static data. I had this problem elsewhere, and am using hoistNonReactStatic to solve it, as described in the react docs. |
Thanks for the workaround 👍 |
@grigored That works for me, except I needed to add 'default' to the export since I had it in a separate file. I would LOVE to see this in the official docs. Also, to get the @codepush decorator to work, I had to install https://github.com/skevy/babel-preset-react-native-stage-0 That required modifying .babelrc, calling watchman watch-del-all, and for my dev system (which doesn't use CodePush but still includes the code), restarting my packager (yarn stop; yarn start). |
@tmaly1980 The decorator is just syntactic sugar, you don't have to use it. It's equivalent to the code below
|
I did this way but my codepush get rollback a lot, about 33% got rollback. Does anyone get this problem? |
Thanks so much for filing an issue or feature request! Please fill out the following (wherever relevant):
Description
When using wix/react-native-navigation/ , code update works fine until restarting the app. Then it rollbacks to the previous version.
Reproduction
git clone https://github.com/JuneDomingo/movieapp
src/app.ios.js
by adding @codepush decorator, the app gets stuck, so I tried Client sdk tests #4 belowAdditional Information
(The more info the faster we will be able to address it!)
The text was updated successfully, but these errors were encountered: