remove duplicate conditions. add missing ; #918
Conversation
src/native-common/View.tsx
Outdated
| const macAccessibilityProps: MacComponentAccessibilityProps = accessibilityProps as any; | ||
| if (this.props.tabIndex !== -1) { | ||
|
|
||
| if (this.props.tabIndex && this.props.tabIndex >= 0) { |
There was a problem hiding this comment.
This isn't correct. If tabIndex is 0, this condition will fail and the code below is not run
If tab index is undefined and onPress is defined, the code below should be run but is not
The conditional that was previously above is needed on this block, so I don't think it really optimizes anything by moving it
a-tarasyuk
force-pushed
the
feature/remove-duplicate-conditions
branch
from
149bd76
to
f02798a
Compare
| const macAccessibilityProps: MacComponentAccessibilityProps = accessibilityProps as any; | ||
| if (this.props.tabIndex !== -1) { | ||
|
|
||
| if (this.props.tabIndex !== undefined && this.props.tabIndex >= 0) { |
There was a problem hiding this comment.
This is still a change in behaviour. If tabIndex is undefined and onPress is defined, the below code should be run.
You're going to end up with the same conditional that was above
|
Oh, ok. For the first look, it is a little bit confused :). Have closed PR., In my opinion, this condition is too long and would be better to make it simpler or make a method with a readable name which describes the purpose of the condition. Seems case when tabIndex less than -1 causes the error... |
No description provided.