Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to toggle DarkMode on the editor. #226

Merged

Conversation

Lego6245
Copy link
Member

@Lego6245 Lego6245 commented Feb 7, 2019

PR is self describing. I also moved the DarkMode related functions into its own region in Editor.ts.

@Lego6245
Copy link
Member Author

Lego6245 commented Feb 7, 2019

I dunno why this is displaying like there's a bunch of nonsense changes that aren't related. Give me a moment to try to fix this.

@Lego6245 Lego6245 requested review from Adjective-Object, JiuqingSong and titrongt and removed request for Adjective-Object February 7, 2019 19:45
Copy link
Contributor

@Adjective-Object Adjective-Object left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding out on the approve spelling mistakes. indentation issues, & code default args.

Ping me on chat for a quick accept after remediation

packages/roosterjs-editor-core/lib/editor/Editor.ts Outdated Show resolved Hide resolved
packages/roosterjs-editor-core/lib/editor/Editor.ts Outdated Show resolved Hide resolved
packages/roosterjs-editor-core/lib/editor/Editor.ts Outdated Show resolved Hide resolved
packages/roosterjs-editor-core/lib/editor/Editor.ts Outdated Show resolved Hide resolved
packages/roosterjs-editor-core/lib/editor/Editor.ts Outdated Show resolved Hide resolved
packages/roosterjs-editor-core/lib/editor/Editor.ts Outdated Show resolved Hide resolved
packages/roosterjs-editor-core/lib/editor/Editor.ts Outdated Show resolved Hide resolved
@Lego6245 Lego6245 merged commit 81f0691 into microsoft:roosterjs-darkmode-alpha Feb 8, 2019
@Lego6245 Lego6245 deleted the toggleDarkMode branch February 8, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants