New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to toggle DarkMode on the editor. #226
Merged
Lego6245
merged 9 commits into
microsoft:roosterjs-darkmode-alpha
from
Lego6245:toggleDarkMode
Feb 8, 2019
Merged
Add the ability to toggle DarkMode on the editor. #226
Lego6245
merged 9 commits into
microsoft:roosterjs-darkmode-alpha
from
Lego6245:toggleDarkMode
Feb 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 7.1.2 Fix microsoft#218 * Fix typo
I dunno why this is displaying like there's a bunch of nonsense changes that aren't related. Give me a moment to try to fix this. |
Lego6245
requested review from
Adjective-Object,
JiuqingSong and
titrongt
and removed request for
Adjective-Object
February 7, 2019 19:45
titrongt
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding out on the approve spelling mistakes. indentation issues, & code default args.
Ping me on chat for a quick accept after remediation
Adjective-Object
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is self describing. I also moved the DarkMode related functions into its own region in Editor.ts.