Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and fix for error on getting multiple arguments #126

Conversation

Christina-Kang
Copy link
Contributor

@Christina-Kang Christina-Kang commented Oct 5, 2018

Fixes #122

Changes include:

  • Add tests to ensure these commands will get coverage for similar errors
  • Fix command behavior.
  • Note: these failures have not been released, so there is no impact from these errors.
  • Add tests for create application path generation

Verifed:

  • Build and test CI passes
  • History and readme updated to reflect changes
  • Package version updated according to semantic versioning rules
  • Tests modified or added, when applicable
  • Updated code owners file, when applicable
  • Read the PR checklist

@Christina-Kang Christina-Kang force-pushed the fix-multiple-values-for-argument-knack-4.2-upgrade branch from 6d69da4 to ab032c9 Compare October 9, 2018 19:11
@coveralls
Copy link

Coverage Status

Coverage increased (+2.8%) to 85.461% when pulling 74639fc on Christina-Kang:fix-multiple-values-for-argument-knack-4.2-upgrade into f25e471 on Microsoft:master.

@coveralls
Copy link

coveralls commented Oct 19, 2018

Coverage Status

Coverage increased (+2.7%) to 85.867% when pulling ab7ad11 on Christina-Kang:fix-multiple-values-for-argument-knack-4.2-upgrade into 83ca819 on Microsoft:master.

@Christina-Kang Christina-Kang merged commit 05c97a3 into microsoft:master Oct 23, 2018
@Christina-Kang Christina-Kang deleted the fix-multiple-values-for-argument-knack-4.2-upgrade branch October 23, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants