Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stdout fix #84

Merged
merged 4 commits into from May 18, 2017
Merged

Feature/stdout fix #84

merged 4 commits into from May 18, 2017

Conversation

MrMeemus
Copy link
Contributor

Set the PYTHONIOENCODING if it is not set to UTF-8.

This solves the problem of handling the different encoding that can be set during run time which has different behaviors in Python 2 vs Python 3.

@msftclas
Copy link

@MrMeemus,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@@ -3,6 +3,7 @@
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------

import os
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is os used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, will remove. thanks!

@pensivebrian
Copy link
Member

:shipit:

@MrMeemus MrMeemus merged commit 3068573 into dev May 18, 2017
@MrMeemus MrMeemus deleted the feature/stdout_fix branch May 18, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants