Change to scope file tree to the known path if root folders dont return correctly #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a screenshot? |
src/Microsoft.SqlTools.ServiceLayer/FileBrowser/FileBrowserOperation.cs
Outdated
Show resolved
Hide resolved
kburtram
approved these changes
May 24, 2019
|
@udeeshagautam do you know what happened with the code coverage? perhaps some tests are failing? |
|
@kburtram yes, the last run had -1% decline.. so I re-ran and it went -4.5%. Re-ran and it came back to -0.3% decrease. So continuing with merge... |
|
@shueybubbles @chlafreniere would you like to take another look or I should close? |
chlafreniere
approved these changes
May 24, 2019
ranasaria
reviewed
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix microsoft/azuredatastudio#4767 :
Issue : File browser for back up result does not load when the root folders return are not valid and hence the expand path i.e. the default backup path can not be found in those.
Fix: workaround to scope the file browser tree to the default backup path
Following is how it looks when root not found. (Please note that if there is nothing present in the default folder it will show as empty)