Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup DacFx and Schema Compare tests #823

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Cleanup DacFx and Schema Compare tests #823

merged 1 commit into from
Jun 10, 2019

Conversation

kisantia
Copy link
Contributor

Cleaning up DacFx and Schema Compare tests:

  • remove unused RequestContexts
  • formatting

udeeshagautam
udeeshagautam approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@udeeshagautam udeeshagautam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch :) looks like I have the remove context changes in my branch for scmp save too... can you please let me know once you merge and I will merge master back..

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 76.159% when pulling b16df12 on kisantia/cleanupTests into f7c86a8 on master.

@kisantia kisantia merged commit 3566471 into master Jun 10, 2019
@kisantia kisantia deleted the kisantia/cleanupTests branch June 10, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udeeshagautam udeeshagautam udeeshagautam approved these changes

@pensivebrian pensivebrian Awaiting requested review from pensivebrian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kisantia @coveralls @udeeshagautam