Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema compare cancel operation #826

Merged
merged 4 commits into from
Jun 15, 2019
Merged

Schema compare cancel operation #826

merged 4 commits into from
Jun 15, 2019

Conversation

udeeshagautam
Copy link
Contributor

@udeeshagautam udeeshagautam commented Jun 11, 2019 •
edited
Loading

This PR contains cancel operation support for Schema compare.

Added the Latest DacFx nuget

Targets line Item in microsoft/azuredatastudio#5729

pensivebrian
pensivebrian approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@pensivebrian pensivebrian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the (private nuget) distinction in the title? It's on the pubic nuget.org, though in preview.

@coveralls
Copy link

Coverage Status

Coverage increased (+15.9%) to 76.038% when pulling cf309f1 on feature/schemacompare-cancel into 432e054 on master.

@udeeshagautam udeeshagautam changed the title Schema compare cancel operation (private nuget) Schema compare cancel operation Jun 15, 2019
@udeeshagautam
Copy link
Contributor Author

udeeshagautam commented Jun 15, 2019 •
edited
Loading

@pensivebrian added that in title before today :) fixed the title now.

@udeeshagautam udeeshagautam merged commit 3e1f186 into master Jun 15, 2019
@udeeshagautam udeeshagautam deleted the feature/schemacompare-cancel branch June 15, 2019 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pensivebrian pensivebrian pensivebrian approved these changes

@kisantia kisantia kisantia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@udeeshagautam @coveralls @pensivebrian @kisantia