Agent - Fix last step action #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
approved these changes
Jun 14, 2019
| @@ -30,7 +30,7 @@ public static class AgentTestUtils | |||
| Id = 1, | |||
| JobName = job.Name, | |||
| StepName = stepName, | |||
| SubSystem = "T-SQL", | |||
| SubSystem = SqlServer.Management.Smo.Agent.AgentSubSystem.TransactSql, | |||
There was a problem hiding this comment.
Would suggest adding a unit test that has a hardcoded list of all the currently known SMO enum types and verifying that the enum only contains those types so that we can catch newly added types ASAP (for both enums used here)
| @@ -365,6 +365,12 @@ public StepCompletionAction FailureAction | |||
| } | |||
| return this.failureAction; | |||
| } | |||
| set | |||
| { | |||
| if (this.failureAction != value) { | |||
There was a problem hiding this comment.
Seems a little silly to have this check but I guess if that's the pattern I don't have a huge issue with it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/azuredatastudio#5896
Also turned strings to enums
Along with PR in ADS here - microsoft/azuredatastudio#6034