Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to pass Schema compare Operation id from ADS #828

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

udeeshagautam
Copy link
Contributor

This PR contains

Changes for Schema compare operation id to be passed from ADS so that

  1. ADS knows the operation id to cancel if needed without having to wait for operation to return
  2. We can have only one id per SC page so that only the open page's result is stored in memory not the previous compares.
    Test fix to add Cancel call in service call test

Copy link
Contributor

@kisantia kisantia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the open scmp service call to the test :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 76.22% when pulling 5c06048 on bug/schemacompare-CancelCallFix into 3e1f186 on master.

@udeeshagautam udeeshagautam merged commit 347d233 into master Jun 19, 2019
@udeeshagautam udeeshagautam deleted the bug/schemacompare-CancelCallFix branch June 20, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants