Default to Server level context for all OE nodes #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kburtram
approved these changes
Jun 27, 2019
|
@Charles-Gagnon it may be worth noting this in the changelog so it's clear this change in behavior is intended. |
|
@Charles-Gagnon it's probably worth determining the change in code coverage is unrelated. I'd assume it is unless this is breaking a test or something. |
|
Yeah - the code coverage numbers are really sketchy. It's on my backlog to investigate - but I've seen the numbers fluctuate wildly for even simple changes (I've seen changes of up to 17%) so it's likely that same issue here since my changes shouldn't cause this kind of drop in numbers. |
Charles-Gagnon
added a commit
that referenced
this pull request
Jul 26, 2019
This reverts commit a4b6c30. (cherry picked from commit 7512a2bbe3154e4dd4b63927fcba52db78424994)
Charles-Gagnon
added a commit
that referenced
this pull request
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before :
After :