Added endpoint for fetching all notebook jobs #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aasimkhan30
requested review from
abist,
anthonydresser,
kevcunnane and
chlafreniere
…istent with the rest of the codebase
kburtram
reviewed
Jul 11, 2019
kburtram
reviewed
Jul 11, 2019
kburtram
reviewed
Jul 11, 2019
kburtram
reviewed
Jul 11, 2019
kburtram
reviewed
Jul 11, 2019
kburtram
reviewed
Jul 11, 2019
src/Microsoft.SqlTools.ServiceLayer/Agent/Contracts/AgentNotebookRequest.cs
Outdated
Show resolved
Hide resolved
kburtram
reviewed
Jul 11, 2019
src/Microsoft.SqlTools.ServiceLayer/Agent/Contracts/AgentNotebookRequest.cs
Show resolved
Hide resolved
kburtram
reviewed
Jul 11, 2019
kburtram
requested changes
Jul 11, 2019
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/Agent/AgentNotebookTests.cs
Outdated
Show resolved
Hide resolved
…fetch template, materialized notebook endpoints. This will make the Notebook Request and Notebook History responses lighter.
src/Microsoft.SqlTools.ServiceLayer/Agent/Common/AgentUtilities.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ServiceLayer/Agent/Contracts/AgentNotebookRequest.cs
Show resolved
Hide resolved
src/Microsoft.SqlTools.ServiceLayer/LanguageServices/LanguageService.cs
Outdated
Show resolved
Hide resolved
…into feat/notebookendpoints
any injection attacks
leading zeros
kburtram
approved these changes
Aug 14, 2019
src/Microsoft.SqlTools.ServiceLayer/Agent/Contracts/AgentNotebookRequest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ServiceLayer/Agent/Contracts/AgentNotebookRequest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ServiceLayer/Agent/Contracts/AgentNotebookRequest.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/Agent/AgentNotebookTests.cs
Show resolved
Hide resolved
…into feat/notebookendpoints
and fixed other stuff mentioned in the PR.
aasimkhan30
dismissed
Charles-Gagnon’s stale review
Hi Charles, I've made the required changes. Please re-review.
aasimkhan30
removed request for
anthonydresser,
abist,
kevcunnane and
chlafreniere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a simple endpoint that fetches all the notebook jobs accessible by the user. To be used in ADS, AgentViewComponent.