Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Default to Server level context for all OE nodes (#829)" #838

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

Charles-Gagnon
Copy link
Contributor

Fixes microsoft/azuredatastudio#6497 microsoft/azuredatastudio#6394

This reverts commit a4b6c30. Two reasons for reverting this :

  1. There's been numerous complaints (Connections on connections panel now go to server root instead of selected database azuredatastudio#6394) about the change in behavior
  2. It broke Data Explorer nodes and while the long term "best" fix may be to have a single connection per node and then have child nodes update their context appropriately - but this is going to require more investigation and time to implement correctly so doing this lets us fix the completely broken experience until that can be done correctly

This reverts commit a4b6c30.

(cherry picked from commit 7512a2bbe3154e4dd4b63927fcba52db78424994)
@coveralls
Copy link

Coverage Status

Coverage increased (+4.9%) to 76.433% when pulling 6898868 on chgagnon/revertConnectionContext into f7a7a3d on master.

@Charles-Gagnon
Copy link
Contributor Author

@kburtram @kevcunnane I'm planning on merging this in today unless either of you have any issue with this

@Charles-Gagnon Charles-Gagnon merged commit ec09ad2 into master Jul 29, 2019
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/revertConnectionContext branch July 29, 2019 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New bdc explorer renders sql object tree incorrectly.
3 participants