-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sqlcmd : Enable running scripts with SQLCMD variables - Part 1 #839
Conversation
src/Microsoft.SqlTools.ManagedBatchParser/BatchParser/BatchParserWrapper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ManagedBatchParser/BatchParser/BatchParserWrapper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ManagedBatchParser/BatchParser/BatchParserWrapper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ManagedBatchParser/BatchParser/ExecutionEngineCode/ExecutionEngine.cs
Show resolved
Hide resolved
src/Microsoft.SqlTools.ServiceLayer/SqlContext/QueryExecutionSettings.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.SqlTools.ManagedBatchParser.IntegrationTests/BatchParser/BatchParserTests.cs
Show resolved
Hide resolved
test/Microsoft.SqlTools.ManagedBatchParser.IntegrationTests/BatchParser/BatchParserTests.cs
Show resolved
Hide resolved
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/LanguageServer/LanguageServiceTests.cs
Show resolved
Hide resolved
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/LanguageServer/LanguageServiceTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/LanguageServer/LanguageServiceTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/LanguageServer/LanguageServiceTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/LanguageServer/LanguageServiceTests.cs
Show resolved
Hide resolved
src/Microsoft.SqlTools.ManagedBatchParser/BatchParser/BatchParserWrapper.cs
Show resolved
Hide resolved
src/Microsoft.SqlTools.ManagedBatchParser/BatchParser/BatchParserWrapper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ManagedBatchParser/BatchParser/BatchParserWrapper.cs
Show resolved
Hide resolved
…ther options in batch info
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/DisasterRecovery/BackupServiceTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test/Microsoft.SqlTools.ManagedBatchParser.IntegrationTests/BatchParser/BatchParserTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/LanguageServer/LanguageServiceTests.cs
Show resolved
Hide resolved
test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/LanguageServer/LanguageServiceTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ManagedBatchParser/BatchParser/ExecutionEngineCode/ExecutionEngine.cs
Show resolved
Hide resolved
even though this is not your change I suggest changing returns of Task.FromResult(true) to Task.CompletedTask. The previous code was the best option before .Net 4.6. But from .Net 4.6 it is best to use this predefined constant. Here is some discussion on this topic: Refers to: src/Microsoft.SqlTools.ServiceLayer/LanguageServices/LanguageService.cs:1758 in 26eca53. [](commit_id = 26eca53, deletion_comment = False) |
This contains: