Update dacfx to latest preview #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pensivebrian
reviewed
Aug 8, 2019
| @@ -185,7 +191,7 @@ public class DeploymentOptions | |||
| ObjectType.LinkedServerLogins, | |||
| ObjectType.Endpoints, | |||
| ObjectType.ErrorMessages, | |||
| ObjectType.Filegroups, | |||
| ObjectType.Files, | |||
| ObjectType.Logins, | |||
There was a problem hiding this comment.
Should we leave this to be explicit?
There was a problem hiding this comment.
Both will be present in options allowing user to change... only that Files will be excluded and groups included by default (following SSDT defaults).
(Files should not be by default included because they in most cases fail the deployment - one will have to explicitly exclude the changes regarding db files for it to work. Earlier it used to work because Filegroup meant both - files and filegroups)
There was a problem hiding this comment.
I see. Thanks makes sense. Thanks!
…ot there previously)
kisantia
approved these changes
Aug 8, 2019
…ot there previously)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in