Add Schema Compare support for AAD #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(weird issue not letting me add comment in code) SchemacompareUtils.cs line 121 : |
|
(also not letting me edit the comment :( ) One more thing, I noticed one SC test failed in PR build... please confirm locally that all SC tests are passing with the change |
udeeshagautam
approved these changes
Aug 22, 2019
|
@udeeshagautam added null check and the test passed when I ran it locally with the changes. |
src/Microsoft.SqlTools.ServiceLayer/SchemaCompare/SchemaCompareUtils.cs
Outdated
Show resolved
Hide resolved
…to CreateSchemaCompareEndpoint()
Benjin
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for AAD in schema compare by passing the AzureAcountToken if there is one. Fixes microsoft/azuredatastudio#5123