add nullable serialization to flags converters #857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft.SqlTools.Hosting.v2 uses data contracts that have nullable [Flags] enums. For example:
sqltoolsservice/src/Microsoft.SqlTools.DataProtocol.Contracts/ClientCapabilities/Workspace/Symbol.cs
Line 35 in 361287a
However, this request causes exception in the serialization code because it does not handle the nullables:
sqltoolsservice/src/Microsoft.SqlTools.DataProtocol.Contracts/Utilities/FlagsIntConverter.cs
Line 29 in 361287a
The proposed change fixes the deserialization issue.