Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nullable serialization to flags converters #857

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

sergei-boguslavski
Copy link
Contributor

Microsoft.SqlTools.Hosting.v2 uses data contracts that have nullable [Flags] enums. For example:

. It is supposed to be restored from this json which was copy-pasted from the "initialize" request sent by sqlops data client:

"symbol": {
  "dynamicRegistration": true,
    "symbolKind": {
        "valueSet": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26]
    }
},

However, this request causes exception in the serialization code because it does not handle the nullables:

The proposed change fixes the deserialization issue.

@msftclas
Copy link

msftclas commented Aug 29, 2019

CLA assistant check
All CLA requirements met.

@kevcunnane kevcunnane merged commit c6e3b33 into microsoft:master Aug 29, 2019
@coveralls
Copy link

coveralls commented Aug 30, 2019

Coverage Status

Coverage decreased (-0.03%) to 76.756% when pulling 1354a4c on sergei-boguslavski:master into 55c82fb on microsoft:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants