Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support php 8.2 readonly classes, constants in traits, true type #368

Merged
merged 4 commits into from Aug 18, 2022
Merged

Support php 8.2 readonly classes, constants in traits, true type #368

merged 4 commits into from Aug 18, 2022

Conversation

TysonAndre
Copy link
Contributor

  1. Support https://wiki.php.net/rfc/readonly_classes - the class modifiers become repeatable, it becomes a compile error rather than a parse error to repeat modifiers or to combine abstract&final
  2. Support https://wiki.php.net/rfc/constants_in_traits
  3. Support parsing https://wiki.php.net/rfc/true-type

@TysonAndre
Copy link
Contributor Author

@roblourens thoughts?

roblourens
roblourens approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens roblourens merged commit 9bf6637 into microsoft:main Aug 18, 2022
@TysonAndre TysonAndre deleted the php8.2-features branch August 19, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TysonAndre @roblourens