Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System.register from UMD header #18

Merged
merged 2 commits into from
Dec 22, 2016
Merged

Remove System.register from UMD header #18

merged 2 commits into from
Dec 22, 2016

Conversation

rbuckton
Copy link
Member

This PR removes System.register from the UMD header of tslib.js in favor of System's built in module format detection. This fixes an issue with how tslib.js loads when running inside of JSPM/SystemJS.

Fixes: microsoft/TypeScript#12887

@rbuckton rbuckton merged commit e633121 into master Dec 22, 2016
@rbuckton
Copy link
Member Author

@DanielRosenwasser can you publish an update to npm?

@DanielRosenwasser DanielRosenwasser deleted the fix12887 branch December 26, 2016 03:03
@aluanhaddad
Copy link
Contributor

aluanhaddad commented Jan 1, 2017

@rbuckton Just FYI, the global System is currently slated to be removed so as to not conflict with the System global proposed in TC39.
The current recommendation is to use the SystemJS global. This shouldn't affect module emit, at least for the time being, as a wrapper providing both names is currently injected.

You can see SystemJS rename to window.SystemJS over window.System for details.

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tslib not working for JSPM
3 participants