Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDAL 1.7.1 #3452

Merged
merged 2 commits into from May 18, 2018
Merged

Add PDAL 1.7.1 #3452

merged 2 commits into from May 18, 2018

Conversation

mloskot
Copy link
Contributor

@mloskot mloskot commented May 7, 2018

First stab at porting PDAL (https://pdal.io), creates package:

  • with minimal set of required dependencies
  • with dynamic library only - dependency GDAL does not build as static
  • with pdal executable

Test

Executable

 d:\vcpkg\installed\x64-windows\tools\pdal\pdal.exe --version
--------------------------------------------------------------------------------
pdal 1.7.1 (git-version: c795e3)
--------------------------------------------------------------------------------

Library

  • CMakeLists.txt
cmake_minimum_required(VERSION 3.5)
project(test_vcpkg CXX)
find_package(PDAL REQUIRED)
include_directories(${PDAL_INCLUDE_DIRS})
add_executable(use_pdal use_pdal.cpp)
target_link_libraries(use_pdal PRIVATE pdalcpp pdal_util pdal_boost pdal_arbiter pdal_kazhdan)
  • use_pdal.cpp
#include <pdal/pdal.hpp>
int main()
{
    pdal::Options options;
    options.add("filename", "myfile.las");
}
  • Run cmake
cd use_pdal & mkdir _build & cd _build
cmake -DCMAKE_TOOLCHAIN_FILE=d:\vcpkg\scripts\buildsystems\vcpkg.cmake -G "Visual Studio 15 2017 Win64" ..
cmake --build .

Successfully compiled and linked.

First stab at porting PDAL (https://pdal.io), creates package:
- with minimal set of required dependencies
- with dynamic library only - dependency GDAL does not build as static
- with pdal executable
@ras0219-msft ras0219-msft self-assigned this May 18, 2018
@ras0219-msft ras0219-msft merged commit 2978f18 into microsoft:master May 18, 2018
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

I removed the explicit check for static libs since it is generally "reasonable" to build static libs on top of DLLs (though certainly less reasonable to do the reverse!)

@mloskot mloskot deleted the ml/pdal-1.7.1 branch May 18, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants