[stormlib] Add new port #6428
Merged
[stormlib] Add new port #6428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @stijnherfst, thanks for the new port. I see that the port failed on all triplets. |
|
It seems that the build failed again on the build server? Is there a way I can get the logs myself or set up an environment that will produce the same errors? The package installs correctly on my machine for both x86/x64 shared/static. |
|
The port only build failed on these three triplets from the current CI system.
|
|
I changed the dependencies which should fix the error on x64-linux. UWP is not intended as a supported target for the library. |
|
Did the build succeed for x64-linux this time? |
|
Yep! The port is passing on all triplets save UWP. Thanks for the port contribution, @stijnherfst! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the StormLib library. Right now there is a patch to avoid the output of testing binaries, but this can be removed once the author finishes a new release as a fix is coming.