Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[assimp]Fix lrrXML library dependencies. #6593

Merged
merged 5 commits into from
Jun 1, 2019
Merged

[assimp]Fix lrrXML library dependencies. #6593

merged 5 commits into from
Jun 1, 2019

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented May 24, 2019

Related: #5012.

@akaltar, could you have a look?

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label May 24, 2019
@Neumann-A
Copy link
Contributor

Changing the config in that way always tells me that there is something wrong with a find_library call within the port: It is probably missing to look for debug and release libraries + a select_library_configurations call. same goes for the explicit passing of some libraries in vcpkg_configure_cmake.

    OPTIONS_RELEASE
            -DZLIB_LIBRARIES=${CURRENT_INSTALLED_DIR}/lib/zlib.lib
            -DZLIB_LIBRARY=${CURRENT_INSTALLED_DIR}/lib/zlib.lib
    OPTIONS_DEBUG
            -DZLIB_LIBRARIES=${CURRENT_INSTALLED_DIR}/debug/lib/zlibd.lib
            -DZLIB_LIBRARY=${CURRENT_INSTALLED_DIR}/debug/lib/zlibd.lib

should be at least changed to:

    OPTIONS
            -DZLIB_LIBRARIES=debug;${CURRENT_INSTALLED_DIR}/debug/lib/zlibd.lib;optimized;${CURRENT_INSTALLED_DIR}/lib/zlib.lib
            -DZLIB_LIBRARY=debug;${CURRENT_INSTALLED_DIR}/debug/lib/zlibd.lib;optimized;${CURRENT_INSTALLED_DIR}/lib/zlib.lib

even better would be if information about zlib would be found by find_package(zlib REQUIRED) within the package itself.

@JackBoosY JackBoosY marked this pull request as ready for review May 27, 2019 06:17
@JackBoosY
Copy link
Contributor Author

Hi @Neumann-A, is that correct now?

@JackBoosY
Copy link
Contributor Author

All checks are OK, please merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants