[reproc] Enabled C++ target for version 6.0.0. #6711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 31, 2019 18:04
|
/azp run |
|
Eh... I don't follow. Did I do something wrong? Forgot a check? |
|
Nope, we just had a hiccup in the pipeline :) Thanks for the PR! |
|
@qis Any suggestions on how I can improve the reproc CMake scripts? cddm just installs each configured library to the standard cmake install directories. This works perfectly with the Unix directory structure but unfortunately vcpkg does not like a package installing multiple targets. I made an issue (#4888) to improve the situation but unfortunately there hasn't been any response yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the upgrade to version 6.0.0 the C++ target is neither built nor installed.
This PR fixes the build and install part, but leaves the usasge message alone since the cmake scripts are generated using a broken library (cddm) and don't work.
The library (both,
reprocandreproc++) can still be used when linking manually.