[casclib] Add new port

[stijnherfst]

Add support for the CascLib library. This library does not target UWP as a platform.

[Rastaban]

I also see a failure on Mac, is that expected?

[stijnherfst]

I also see a failure on Mac, is that expected?

No, it should work on Mac OS. Could you send me the failure logs? I can only access the failure logs for Windows and Linux it seems.

[Rastaban]

We are in the process of bringing up a new osx test pipeline that is accessible by the community. You can find the logs in that new pipeline here: https://dev.azure.com/vcpkg/public/_build/results?buildId=1566&view=results. If you run into issues getting these logs let me know so I can fix the pipeline.

Link directly to the logs: https://dev.azure.com/vcpkg/c1ee48cb-0df2-4ab3-8384-b1df5a79fe53/_apis/build/builds/1566/artifacts?artifactName=port%20build%20failure%20logs&api-version=5.1-preview.5&%24format=zip

[Rastaban]

/azp run

[Rastaban]

It looks like the build is not finding isxdigit from <cctype>.

src/CascFiles.cpp:161:39: error: use of undeclared identifier 'isxdigit'
        if (szDataPtr >= szDataEnd || isxdigit(szDataPtr[0]) == 0)
                                      ^

I don't have access to a Mac right now, but my guess is that is indirectly included, and the version of the tools used on our Mac test machine is a different version than what you have so the file is not getting pulled in. I bet if you add a patch that puts #include <cctype> into src/CascCommon.h then it will fix the build issue.

[Rastaban]

It looks like <ctype.h> is included in CascPort.h for Windows/Linux but not for Mac. I have it open so I will just add the patch to see if that makes the CI system happy.

[Rastaban]

OSX is happy now :)

[stijnherfst]

Thanks for solving the issues with Mac compilation! I was very busy lately so didn't get to it.