Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FFmpeg] Add support for VP8/VP9 codecs #6784

Merged
merged 1 commit into from
Jun 10, 2019
Merged

[FFmpeg] Add support for VP8/VP9 codecs #6784

merged 1 commit into from
Jun 10, 2019

Conversation

emptyVoid
Copy link
Contributor

Added vpx feature to ffmpeg to support WebM VP8/VP9 codecs.

Resolves #6449.

@emptyVoid
Copy link
Contributor Author

Same errors again (see #6729 (comment)):

error: failed to update mingw32 (unable to lock database)
error: failed to update mingw64 (unable to lock database)
error: failed to update msys (unable to lock database)
error: failed to synchronize all databases

@cbezault
Copy link
Contributor

cbezault commented Jun 7, 2019

Sorry about those database locking errors, we're working on ironing them out. I just want to make sure that this PR is only meant to enable VP8/VP9 on Windows right?

@cbezault cbezault self-assigned this Jun 7, 2019
@emptyVoid
Copy link
Contributor Author

Yes, enabling VP8/VP9 on Windows only. Should work for other platforms too, though libvpx port currently supports Windows only.

@cbezault
Copy link
Contributor

I'm going to allow this for now because it works for you and doesn't break anything else but the mechanism you are using to detect whether or not we're compiling a debug library will only work on windows. A better fix would have been to work on the upstream port. I'm going to be doing just that for BZip2 to get it to work with ffmpeg without the kind of patching you did so I might revisit this then.

@cbezault cbezault merged commit 0598158 into microsoft:master Jun 10, 2019
@emptyVoid emptyVoid deleted the add-ffmpeg-vpx-support branch June 11, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cbezault cbezault

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FFmpeg] [Feature request] Add support for VP8/VP9 codec
2 participants
@emptyVoid @cbezault