Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[darknet] update to latest release #6787

Merged
merged 3 commits into from
Jun 24, 2019

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Jun 5, 2019

Partially solves some problems explained in #6120 (I edited to avoid the verb "fixes" which would have triggered a closed-issue after merging this pr...) for what concern darknet. It took a little bit longer than expected but it is fixed upstream so it should be the best option here

@cenit
Copy link
Contributor Author

cenit commented Jun 5, 2019

also in the newer release I did a lot of rework for people using darknet as a library. Waiting for feedback on it, i hope it's well accepted

@cenit cenit force-pushed the dev/cenit/darknet_include branch from 884e40b to 0c46d57 Compare June 7, 2019 13:20
@cenit
Copy link
Contributor Author

cenit commented Jun 10, 2019

please wait a little bit before merge. All these changes will be implemented very soon also upstream, reducing patch size even more

@ras0219-msft
Copy link
Contributor

Thanks for the notice!

Could you close this PR and re-open it as a draft PR [1]? Draft PRs are great because you can decide when to promote it to be ready for merging.

[1] https://github.blog/2019-02-14-introducing-draft-pull-requests/

@cenit cenit force-pushed the dev/cenit/darknet_include branch from 1a0edb9 to f0c72b1 Compare June 13, 2019 20:00
@cenit
Copy link
Contributor Author

cenit commented Jun 13, 2019

Thanks for the notice!

Could you close this PR and re-open it as a draft PR [1]? Draft PRs are great because you can decide when to promote it to be ready for merging.

[1] https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ras0219-msft sorry I didn't read last message.
Anyway, just updated with latest revision. It does not require any patch anymore. If CI is ok, IMHO we can remove the wip tag @cbezault

@cenit
Copy link
Contributor Author

cenit commented Jun 21, 2019

@cbezault any particular request on this PR?

@Rastaban Rastaban merged commit aefbaa1 into microsoft:master Jun 24, 2019
@cenit cenit deleted the dev/cenit/darknet_include branch June 25, 2019 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants