Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[immer] Add new port #6814

Merged
merged 3 commits into from
Jun 9, 2019
Merged

[immer] Add new port #6814

merged 3 commits into from
Jun 9, 2019

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Jun 7, 2019

Fix #6764 .

@myd7349 myd7349 marked this pull request as ready for review June 7, 2019 12:41
@myd7349
Copy link
Contributor Author

myd7349 commented Jun 7, 2019

arximboldi/immer#85

@myd7349
Copy link
Contributor Author

myd7349 commented Jun 7, 2019 •
edited
Loading

TODO: Remove the patch.

@cbezault
Copy link
Contributor

cbezault commented Jun 7, 2019

@myd7349 does that TODO mean this PR isn't ready yet?

@cbezault cbezault self-assigned this Jun 7, 2019
@myd7349
Copy link
Contributor Author

myd7349 commented Jun 8, 2019

Hi! @cbezault I have just removed the patch file which has already been merged in the upstream repo.

@ras0219-msft ras0219-msft merged commit a6960ed into microsoft:master Jun 9, 2019
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

@myd7349 myd7349 deleted the immer-init branch June 9, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cbezault cbezault

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New port request] immer
3 participants
@myd7349 @cbezault @ras0219-msft